[19.0][MIG] queue_job_subscribe: Migration to 19.0 - #980
Closed
dhongu wants to merge 1 commit into
Closed
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
Contributor
Author
|
Closing as duplicate of #975, which is identical (same five files, same changes) and already has three approvals plus the For what it is worth, the confirmation carries over to #975: I installed that exact change on a clean 19.0 database and the module's own suite passes — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
queue_job_subscribefrom 18.0 to 19.0.The only code change 19.0 required is in the tests:
res.users.groups_idwasrenamed to
group_ids, both in thecreate()values and in the twosearch()domains. The model itself (res_users.subscribe_joband thequeue.jobfollower logic) needed nothing.The rest is the usual migration housekeeping: version bump to
19.0.1.0.0,installable: True, the addon removed from the not-installable exclude list in.pre-commit-config.yaml, andREADME.rst/static/description/index.htmlregenerated for the 19.0 branch.
With the addon no longer excluded,
pre-commitnow runs over it and passes clean.Test
Installed and ran the module's own test suite on a fresh 19.0 database:
Both scenarios (
test_job_subscription_all_follow,test_job_subscription_not_follow) pass, so the group-based follower selectionworks through the renamed field.