Skip to content

[19.0][MIG] queue_job_subscribe: Migration to 19.0 - #980

Closed
dhongu wants to merge 1 commit into
OCA:19.0from
dhongu:19.0-mig-queue_job_subscribe
Closed

[19.0][MIG] queue_job_subscribe: Migration to 19.0#980
dhongu wants to merge 1 commit into
OCA:19.0from
dhongu:19.0-mig-queue_job_subscribe

Conversation

@dhongu

@dhongu dhongu commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Migration of queue_job_subscribe from 18.0 to 19.0.

The only code change 19.0 required is in the tests: res.users.groups_id was
renamed to group_ids, both in the create() values and in the two
search() domains. The model itself (res_users.subscribe_job and the
queue.job follower logic) needed nothing.

The rest is the usual migration housekeeping: version bump to 19.0.1.0.0,
installable: True, the addon removed from the not-installable exclude list in
.pre-commit-config.yaml, and README.rst / static/description/index.html
regenerated for the 19.0 branch.

With the addon no longer excluded, pre-commit now runs over it and passes clean.

Test

Installed and ran the module's own test suite on a fresh 19.0 database:

odoo.tests.stats: queue_job_subscribe: 4 tests 0.27s 390 queries
odoo.tests.result: 0 failed, 0 error(s) of 2 tests

Both scenarios (test_job_subscription_all_follow,
test_job_subscription_not_follow) pass, so the group-based follower selection
works through the renamed field.

@oca-cla-bot

oca-cla-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@OCA-git-bot OCA-git-bot added series:19.0 mod:queue_job_subscribe Module queue_job_subscribe labels Sep 9, 2026
@dhongu

dhongu commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #975, which is identical (same five files, same changes) and already has three approvals plus the approved label. I opened this before checking the open PRs — apologies for the noise.

For what it is worth, the confirmation carries over to #975: I installed that exact change on a clean 19.0 database and the module's own suite passes — queue_job_subscribe: 4 tests, 0 failed, 0 error(s). It only needs a maintainer to press merge.

@dhongu dhongu closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:queue_job_subscribe Module queue_job_subscribe series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants