fix(server): reject malformed message cursors - #48037
Open
IbrahimKhan12 wants to merge 1 commit into
Open
Conversation
- Decode message cursors with strict Base64URL validation. - Cover invalid cursor characters in the session API test.
IbrahimKhan12
marked this pull request as ready for review
September 8, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48034
Type of change
What does this PR do?
Message pagination used Node's permissive Base64URL decoder, which ignored invalid characters. This uses Effect's strict decoder before the existing cursor schema validation, matching session pagination. Malformed cursors now reach the existing
InvalidCursorErrorresponse path.How did you verify your code works?
bun test test/server/httpapi-session.test.ts -t "returns v2 public request errors for cursor and workspace query failures"bun test --timeout 10000 test/server/httpapi-session.test.tsbun typecheckbunx prettier --check packages/server/src/handlers/message.ts packages/opencode/test/server/httpapi-session.test.tsScreenshots / recordings
Not applicable.
Checklist