Fix task error email notification sender fallback to connection and provider defaults - #72745
Open
olayiwola-gbenga wants to merge 1 commit into
Open
Conversation
olayiwola-gbenga
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
September 8, 2026 21:05
…rovider defaults In Task SDK, _send_error_email_notification passed a hardcoded fallback string 'airflow@airflow' when [email] from_email was not configured. This bypassed provider-specific defaults (such as SendGrid's SENDGRID_MAIL_FROM env var or SES sender verification) when using _LegacyEmailBackendNotifier, and prevented SmtpNotifier from reaching its connection-extra fallback branch. Default from_email extraction to None so backends and notifiers can resolve their own sender defaults.
olayiwola-gbenga
force-pushed
the
fix-error-email-from-email-fallback
branch
from
September 8, 2026 21:14
c95a444 to
4a37d3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Task SDK, _send_error_email_notification passed a hardcoded fallback string 'airflow@airflow' when [email] from_email was not configured. This bypassed provider-specific defaults (such as SendGrid's SENDGRID_MAIL_FROM env var or SES sender verification) when using _LegacyEmailBackendNotifier, and prevented SmtpNotifier from reaching its connection-extra fallback branch.
Default from_email extraction to None so backends and notifiers can resolve their own sender defaults.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.