Skip to content

Fix task error email notification sender fallback to connection and provider defaults - #72745

Open
olayiwola-gbenga wants to merge 1 commit into
apache:mainfrom
VladaZakharova:fix-error-email-from-email-fallback
Open

Fix task error email notification sender fallback to connection and provider defaults#72745
olayiwola-gbenga wants to merge 1 commit into
apache:mainfrom
VladaZakharova:fix-error-email-from-email-fallback

Conversation

@olayiwola-gbenga

Copy link
Copy Markdown
Contributor

In Task SDK, _send_error_email_notification passed a hardcoded fallback string 'airflow@airflow' when [email] from_email was not configured. This bypassed provider-specific defaults (such as SendGrid's SENDGRID_MAIL_FROM env var or SES sender verification) when using _LegacyEmailBackendNotifier, and prevented SmtpNotifier from reaching its connection-extra fallback branch.

Default from_email extraction to None so backends and notifiers can resolve their own sender defaults.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

…rovider defaults

In Task SDK, _send_error_email_notification passed a hardcoded fallback string 'airflow@airflow' when [email] from_email was not configured. This bypassed provider-specific defaults (such as SendGrid's SENDGRID_MAIL_FROM env var or SES sender verification) when using _LegacyEmailBackendNotifier, and prevented SmtpNotifier from reaching its connection-extra fallback branch.

Default from_email extraction to None so backends and notifiers can resolve their own sender defaults.
@olayiwola-gbenga
olayiwola-gbenga force-pushed the fix-error-email-from-email-fallback branch from c95a444 to 4a37d3b Compare September 8, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant