[v3-3-test] Fix ExternalTaskSensor example Dag never finding its parent task (#72480) - #72751
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[v3-3-test] Fix ExternalTaskSensor example Dag never finding its parent task (#72480)#72751github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…nt task (#72480) Both example Dags in example_external_task_marker_dag.py used schedule=None, so every run was independently, manually triggered and got its own logical date. ExternalTaskSensor matches task instances by logical date by default, so the child's sensor could never find a matching task instance in the parent Dag, making the example unusable as a template for a working ExternalTaskSensor + ExternalTaskMarker setup. Give both Dags the same recurring schedule so that corresponding parent/child Dag runs share a logical date, as originally diagnosed by a maintainer on the issue. (cherry picked from commit 20fb83c) Co-authored-by: Dheeren Mohta <dheerenmohta@gmail.com> Closes: #13681
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both example Dags in example_external_task_marker_dag.py used
schedule=None, so every run was independently, manually triggered and
got its own logical date. ExternalTaskSensor matches task instances by
logical date by default, so the child's sensor could never find a
matching task instance in the parent Dag, making the example unusable
as a template for a working ExternalTaskSensor + ExternalTaskMarker
setup.
Give both Dags the same recurring schedule so that corresponding
parent/child Dag runs share a logical date, as originally diagnosed by
a maintainer on the issue.
(cherry picked from commit 20fb83c)
Co-authored-by: Dheeren Mohta dheerenmohta@gmail.com
Closes: #13681