Skip to content

fix WriteToBigTable DirectRow - #40042

Open
aIbrahiim wants to merge 3 commits into
apache:masterfrom
aIbrahiim:fix/postcommit-python-arm-bigtable
Open

fix WriteToBigTable DirectRow#40042
aIbrahiim wants to merge 3 commits into
apache:masterfrom
aIbrahiim:fix/postcommit-python-arm-bigtable

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

fixes #30760, fixes #34990

google-cloud-bigtable 2.44 changed DirectRow and PostCommit test_bigtable_write started to fail so the driver uses 2.44 and workers still use 2.42, so pickle loses _pb_mutations

The PR fills _pb_mutations before pickle and before write so old workers can still write the rows

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
R: @igorbernstein2 for label bigtable.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Amar3tto
Amar3tto requested review from Abacn and damccorm September 8, 2026 07:56
@Amar3tto

Amar3tto commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

@Abacn

Abacn commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

cc: @mutianf (for Bigtable client breaking change)

Also we should regenerate Python requirement, especially bump this line:

should fix the issue. cc: @shunping ( regenerate Python requirement then release a new beam-master image)

@shunping

shunping commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

I didn't know there would be an issue on pickling here. How about we just bump the lower bound of bigtable?

Then we can also simplify the current code to only support bigtable>=2.44

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

@Abacn thanks, I can bump bigtable to >=2.44.0 in setup.py and drop the pickle fix

@shunping would you regenerate the Python container requirements and publish a new beam-master image so workers get 2.44 too?

@shunping

shunping commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Sure. We can help generate the new beam image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Python Xlang Gcp Dataflow job is flaky The PostCommit Python Arm job is flaky

4 participants