fix: reject unsupported Substrait aggregation phases - #25045
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25045 +/- ##
==========================================
- Coverage 81.72% 81.72% -0.01%
==========================================
Files 1127 1127
Lines 416310 416318 +8
Branches 416310 416318 +8
==========================================
+ Hits 340224 340226 +2
- Misses 56095 56103 +8
+ Partials 19991 19989 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @goutamadwant thank you for the fix, though I see alexandrefimov mentioned opening a PR. Can you please coordinate with the issue author so we don't duplicate the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The Substrait consumer treats intermediate aggregate phases as complete calls. This can silently return final values when a plan requests intermediate state, or report an unrelated root-schema naming error.
What changes are included in this PR?
INITIAL_TO_RESULTand retainUNSPECIFIEDfor compatibility with existing DataFusion-produced plans.What is the testing strategy for this PR?
INITIAL_TO_INTERMEDIATEaverage over values 1 and 2 returned 1.5 instead of intermediate state.cargo clippy --all-targets --all-features -- -D warningspasses../dev/rust_lint.shpasses, including strict workspace documentation checks.Are there any user-facing changes?
Plans with unsupported aggregate or window phases now fail explicitly instead of being interpreted as complete calls. Existing unspecified-phase plans remain accepted. No public Rust API changes are included. Intermediate-state execution and the separate AVG output-type mismatch are not addressed here.