fix(proto): preserve CSV sink writer options - #25058
Open
buraksenn wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
proto
buraksenn
marked this pull request as draft
September 8, 2026 09:10
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #25058 +/- ##
==========================================
- Coverage 81.74% 81.74% -0.01%
==========================================
Files 1128 1128
Lines 416645 416738 +93
Branches 416645 416738 +93
==========================================
+ Hits 340580 340646 +66
- Misses 55998 56024 +26
- Partials 20067 20068 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
buraksenn
marked this pull request as ready for review
September 8, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The CSV sink protobuf hooks accessed state indirectly, allowing new fields to be omitted silently. Auditing the writer options found that compression level, timezone-aware timestamp format, and line terminator were not represented on the wire, so those settings changed after a physical-plan round trip.
What changes are included in this PR?
CsvSink,CsvSinkExecNode, and the nested CSV sink/writer option messages.Nonefor optional format strings and reject malformed line terminators.The protobuf changes are additive and backward compatible.
What is the testing strategy for this PR?
Expanded the CSV sink round-trip test to cover every writer option, optional defaults, and malformed line terminators.
Validated with:
cargo test -p datafusion-proto --test proto_integration roundtrip_csv_sinkcargo clippy -p datafusion-datasource-csv -p datafusion-proto-common -p datafusion-proto --all-features --tests -- -D warningscargo fmt --all --checkAre there any user-facing changes?
CSV sinks now retain compression level, timezone-aware timestamp formatting, and line terminators across protobuf plan round trips. Invalid wire terminators return an error. The protobuf additions are backward compatible.