perf: reduce invariant-check code generation - #25073
Open
kumarUjjawal wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25073 +/- ##
========================================
Coverage 81.74% 81.75%
========================================
Files 1128 1128
Lines 416645 416795 +150
Branches 416645 416795 +150
========================================
+ Hits 340580 340741 +161
+ Misses 55998 55994 -4
+ Partials 20067 20060 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
check_default_invariantsis generic over eachExecutionPlanimplementation. The compiler therefore generated many copies of its dynamic-expression and input-distribution validation logic.These checks depend only on erased values such as the plan name, children, and dynamic expressions. Sharing the heavier validation paths reduces generated code without changing invariant semantics or the public API.
Local release measurements against
upstream/mainat92746a993:upstream/mainrlibsizepartial_orderingbenchmark binaryThe linked benchmark binary was unchanged because its linker removed unused code. This PR does not claim a measured end-to-end WASM binary reduction.
The added Criterion benchmark showed no runtime regression:
upstream/mainWhat changes are included in this PR?
check_default_invariantssignature and existing error behavior.What is the testing strategy for this PR?
The new unit tests cover:
dyn ExecutionPlan.The following checks pass:
cargo fmt --all cargo clippy --all-targets --all-features -- -D warnings RUST_BACKTRACE=1 cargo test --profile ci \ --exclude datafusion-examples \ --exclude datafusion-benchmarks \ --exclude datafusion-cli \ --workspace --lib --tests --bins \ --features avro,json,backtrace,extended_tests,recursive_protection,parquet_encryptionThe code-size comparison and runtime measurements use the new
invariant_checkCriterion benchmark and release builds ofdatafusion-physical-plan.Are there any user-facing changes?
No.