minor: make MinIO tests more stable - #25092
Open
comphead wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25092 +/- ##
==========================================
- Coverage 81.74% 81.74% -0.01%
==========================================
Files 1128 1128
Lines 416782 416782
Branches 416782 416782
==========================================
- Hits 340712 340705 -7
- Misses 55999 56005 +6
- Partials 20071 20072 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I observed PRs sometimes got kicked out of merge queue because flaky
datafusion-clitests, which require full CI againThe
datafusion-clistorage integration tests (test_cli,test_aws_options,test_s3_url_fallback,test_object_store_profiling) each start their own MinIO container, so a single CI run pulls the image several times concurrently. Any transient Docker failure during that pull fails the test immediately:These errors are transient and clear on a second attempt, so a flaky pull should not fail the job.
Rationale for this change
The
datafusion-clistorage integration tests (test_cli,test_aws_options,test_s3_url_fallback,test_object_store_profiling) each start their own MinIO container, so a single CI run pulls the image several times concurrently. Any transient Docker failure during that pull fails the test immediately:These errors are transient and clear on a second attempt, so a flaky pull should not fail the job.