Skip to content

minor: make MinIO tests more stable - #25092

Open
comphead wants to merge 1 commit into
apache:mainfrom
comphead:chore_ci_dfcli
Open

minor: make MinIO tests more stable#25092
comphead wants to merge 1 commit into
apache:mainfrom
comphead:chore_ci_dfcli

Conversation

@comphead

@comphead comphead commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

I observed PRs sometimes got kicked out of merge queue because flaky datafusion-cli tests, which require full CI again

The datafusion-cli storage integration tests (test_cli, test_aws_options, test_s3_url_fallback, test_object_store_profiling) each start their own MinIO container, so a single CI run pulls the image several times concurrently. Any transient Docker failure during that pull fails the test immediately:

thread 'test_aws_options' panicked at datafusion-cli/tests/cli_integration.rs:607:25:
called `Result::unwrap()` on an `Err` value: "Failed to start MinIO container.
Ensure Docker is running and accessible: failed to pull the image
'minio/minio:RELEASE.2025-02-28T09-55-16Z', error: bytes remaining on stream"

These errors are transient and clear on a second attempt, so a flaky pull should not fail the job.

Rationale for this change

The datafusion-cli storage integration tests (test_cli, test_aws_options, test_s3_url_fallback, test_object_store_profiling) each start their own MinIO container, so a single CI run pulls the image several times concurrently. Any transient Docker failure during that pull fails the test immediately:

thread 'test_aws_options' panicked at datafusion-cli/tests/cli_integration.rs:607:25:
called `Result::unwrap()` on an `Err` value: "Failed to start MinIO container.
Ensure Docker is running and accessible: failed to pull the image
'minio/minio:RELEASE.2025-02-28T09-55-16Z', error: bytes remaining on stream"

These errors are transient and clear on a second attempt, so a flaky pull should not fail the job.

@comphead
comphead requested a review from Jefffrey September 9, 2026 00:08
@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Sep 9, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.74%. Comparing base (ac7b18d) to head (2224af8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25092      +/-   ##
==========================================
- Coverage   81.74%   81.74%   -0.01%     
==========================================
  Files        1128     1128              
  Lines      416782   416782              
  Branches   416782   416782              
==========================================
- Hits       340712   340705       -7     
- Misses      55999    56005       +6     
- Partials    20071    20072       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants