Prepare RC: install Thrift before the release build - #3786
Open
RussellSpitzer wants to merge 1 commit into
Open
Conversation
parquet-format-structures compiles .thrift sources with the thrift binary, but release-prepare-rc.yml never installed it, so the release build failed with "thrift: not found" once it reached module 2. This was masked until now because earlier runs failed on the Nexus deploy of module 1 and never got that far. Reuse dev/ci-before_install.sh — the same script ci-hadoop3.yml uses — so the release build compiles against the Thrift version CI validated against, and a future version bump updates both together. CI_TARGET_BRANCH is deliberately left unset. It makes the script source dev/ci-before_install-<branch>.sh, and the only such script is a master-branch SNAPSHOT check that is irrelevant to a release build. release-publish.yml needs no equivalent change: its only Maven call is ./mvnw -pl . versions:set-property, which compiles nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need thrift to compile and test parquet-format-structures
What changes are included in this PR?
We run the dev cli script which installs thrift
Are these changes tested?
No
Are there any user-facing changes?
No