Skip to content

Add OCO_HOOK_AUTO_UNCOMMENT to environment configuration - #513

Open
barathvk wants to merge 1 commit into
di-sukharev:masterfrom
barathvk:master
Open

Add OCO_HOOK_AUTO_UNCOMMENT to environment configuration#513
barathvk wants to merge 1 commit into
di-sukharev:masterfrom
barathvk:master

Conversation

@barathvk

Copy link
Copy Markdown

The new option OCO_HOOK_AUTO_UNCOMMENT in #494 is not exposed as en environment variable. This PR reads this value from the environment, like other configuration values

@di-sukharev di-sukharev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is needed, and typecheck and unit tests pass, but the resulting merge fails Prettier. Please format src/commands/config.ts and add one config test confirming that OCO_HOOK_AUTO_UNCOMMENT from the environment is parsed as a boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants