Skip to content

Avoid CS9103 race in NetAnalyzers tests - #56144

Draft
nagilson with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-cs9103-failures-timeout
Draft

Avoid CS9103 race in NetAnalyzers tests#56144
nagilson with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-cs9103-failures-timeout

Conversation

Copilot AI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

A Mac Helix shard reported shared CS9103 failures while concurrently decoding MemorySafetyRulesAttribute metadata with pre-fix Roslyn bits.

  • Containment
    • Remove method-level parallelization so NetAnalyzers inherits the repository’s serial MSTest default.
  • Guidance
    • Remove obsolete concurrency guidance from the area instructions.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: nagilson <23152278+nagilson@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CS9103 failures and timeouts in Mac test work item Avoid CS9103 race in NetAnalyzers tests Sep 4, 2026
Copilot AI requested a review from nagilson September 4, 2026 23:36

@Youssef1313 Youssef1313 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we working around a Roslyn bug here?

Running analyzer tests in parallel should be valid and should always work as far as I know.

Do we have better analysis on the problem?

@333fred In case you have idea what could be going on.

@Youssef1313 Youssef1313 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a Roslyn bug that got fixed already in dotnet/roslyn#85131

This shouldn't be merged, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AI discovered CI] Analyzer Mac test work item reports shared CS9103 failures and timeout

3 participants