Skip to content

[GHSA-cp6q-959q-f8rh] Tiptap: mergeAttributes() turns an own __proto__ key into inherited executable DOM attributes - #9396

Closed
joshkel wants to merge 1 commit into
joshkel/advisory-improvement-9396from
joshkel-GHSA-cp6q-959q-f8rh
Closed

[GHSA-cp6q-959q-f8rh] Tiptap: mergeAttributes() turns an own __proto__ key into inherited executable DOM attributes#9396
joshkel wants to merge 1 commit into
joshkel/advisory-improvement-9396from
joshkel-GHSA-cp6q-959q-f8rh

Conversation

@joshkel

@joshkel joshkel commented Sep 7, 2026

Copy link
Copy Markdown

Updates

  • Affected products

Comments
The fix was backported to the v2 line and released as 2.27.3:

@github

github commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there @bdbch! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Copilot AI balanced review requested due to automatic review settings September 7, 2026 22:58
@github-actions
github-actions Bot changed the base branch from main to joshkel/advisory-improvement-9396 September 7, 2026 22:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The correctness of the security-sensitive affected-version boundaries (2.27.3 backport and 3.0.0-next.0 start tag) depends on external package facts that require maintainer verification.

Pull request overview

This PR updates the GitHub-reviewed security advisory GHSA-cp6q-959q-f8rh (a per-object prototype manipulation issue in Tiptap's mergeAttributes()). Previously the advisory declared a single affected range for @tiptap/core (2.0.0-alpha.0 → fixed 3.30.4), which incorrectly implied that the backported v2 fix line was still vulnerable. The PR splits the affected data into two release lines to reflect that the fix was also backported to v2 and released as 2.27.3.

Changes:

  • Split the v3 range so it is scoped to introduced 3.0.0-next.0fixed 3.30.4.
  • Add a second affected entry for @tiptap/core covering the v2 line: introduced 2.0.0-alpha.0fixed 2.27.3.
  • Bump the modified timestamp by one second.
File summaries
File Description
advisories/github-reviewed/2026/09/GHSA-cp6q-959q-f8rh/GHSA-cp6q-959q-f8rh.json Splits the affected versions into distinct v2 and v3 release-line ranges and bumps modified.

Notes from review:

  • JSON is valid; modified (14:44:40Z) is ≥ published (14:44:39Z).
  • Using two separate affected entries for the same package to represent different fixed release lines is consistent with established repo convention (e.g. GHSA-v56q-mh7h-f735.json).
  • The two ranges do not overlap and leave no vulnerable gap between 2.27.3 and 3.0.0-next.0.
  • The narrative details field still states "No fixed release was found," which is now inconsistent with the listed fixed versions, but that text is outside the changed lines so no inline comment is applicable.
  • I could not independently verify (no network) that 2.27.3 and 3.0.0-next.0 are the exact correct boundary tags; the PR description provides supporting npm/commit references.

No blocking code issues were found in the diff.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@G-Rath

G-Rath commented Sep 8, 2026

Copy link
Copy Markdown

This is a duplicate of #9375

@joshkel joshkel closed this Sep 8, 2026
@github-actions
github-actions Bot deleted the joshkel-GHSA-cp6q-959q-f8rh branch September 8, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants