Fix stale codegen references in copilot-instructions.md - #2555
Open
rinceyuan wants to merge 1 commit into
Open
Conversation
nodejs/scripts/generate-session-types.ts and the generate:session-types npm script were both removed by github#464, which replaced them with scripts/codegen and 'npm run generate'. The Java generator path was also missing its java/ prefix.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All updated references match the repository’s current codegen paths and scripts.
Pull request overview
Updates contributor instructions to reference the current centralized code-generation workflow.
Changes:
- Replaces deleted Node.js generator references with
npm run generate. - Corrects the Java generator path.
File summaries
| File | Description |
|---|---|
.github/copilot-instructions.md |
Corrects stale codegen paths and commands. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/copilot-instructions.mdpoints contributors and coding agents at a type-generation entry point that was removed in February. Four references are stale.nodejs/scripts/generate-session-types.tsnpm run generate:session-typesscripts/codegen/java.tsjava/scripts/codegen/java.tsnpm run generate:session-types#464 (
RPC codegen, 2026-02-13) deleted the script and replaced the npm task in the same commit:The document already had the correct command elsewhere, so it contradicted itself — line 67 says
cd nodejs && npm run generatewhile lines 26 and 72 named the deleted task. This aligns them.Verification
generate:session-typessurvived nowhere but this file, and nothing references it after the change:Every path the file now claims resolves:
scripts/codegenis confirmed as the producer of the Node output that line 72 describes:Scope
Only the four stale references. The Maven command on line 71 is left as-is — the
codegenprofile is real (java/sdk/pom.xml, whose own comment documentsmvn generate-sources -Pcodegen), and itsworkingDirectoryis${project.parent.basedir}/scripts/codegen, which confirmsjava/scripts/codegenas the correct generator location.