ci: check protocol version drift across all SDKs - #2568
Open
xianjianlf2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1165.
Codegen Check explicitly validates only Java's protocol constant, and changes to the other SDK constants do not trigger it. Extend the check to all six SDKs and include the constants plus the protocol-version generator in the workflow paths. A mismatch or missing declaration produces a file-specific annotation before installing codegen dependencies.
This validates the declared values against
sdk-protocol-version.jsonwithout regenerating the files. It extends the existing Java consistency check and stays independent of the generator template fixes in #2554; generated source and language-specific declaration shapes remain unchanged.Validation: parsed the workflow and executed its exact Node check in temporary fixtures for 15 cases: valid baseline, six individual version mismatches, six missing declarations, a source-version bump, and invalid source metadata. Verified all six constant paths and the generator trigger the workflow. Actionlint 1.7.7 and
git diff --checkpassed. The full schema-generation workflow was not run locally. Codex assisted with this change and validation.