fix: roll back bundle installs when record save fails - #4469
Open
marcelsafin wants to merge 1 commit into
Open
Conversation
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The rollback boundary now covers record persistence, with regression tests and no unresolved issues.
Pull request overview
Extends bundle installation rollback to cover provenance record creation and persistence failures.
Changes:
- Moves bundle record persistence inside the existing rollback boundary.
- Adds regression coverage for record-save failures.
File summaries
| File | Description |
|---|---|
tests/integration/test_bundler_install_flow.py |
Verifies save failures roll back newly installed components and records. |
src/specify_cli/bundler/services/installer.py |
Rolls back newly installed components when provenance persistence fails. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include bundle provenance persistence in the install rollback boundary.
Previously, a failure while saving
bundles.jsonoccurred after the protectedinstall block. Newly installed components remained on disk without a
provenance record, so later bundle operations could not manage them. Record
creation and saving now trigger the existing bounded rollback for components
installed by the current call.
Testing
uv run specify --helpuv sync && uv run pytestTargeted:
tests/integration/test_bundler_install_flow.py(22 passed).Full suite: 7,532 passed, 195 skipped. One existing PowerShell-launcher test
was omitted because
pwshis unavailable locally; it fails identically on theunchanged upstream commit.
AI Disclosure
GitHub Copilot (GPT-5.6 Sol) autonomously reproduced the bug, wrote the
regression test and implementation, and ran verification under
@marcelsafin's direction and review.