Type window.opener as nullable WindowProxy - #64212
Closed
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 3 commits into
Closed
Type window.opener as nullable WindowProxy#64212Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 3 commits into
window.opener as nullable WindowProxy#64212Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 3 commits into
Conversation
typescript-automation
Bot
added
the
For Milestone Bug
Copilot started work on behalf of
Ryan Cavanaugh (RyanCavanaugh)
September 9, 2026 10:22
View session
typescript-automation
Bot
added
For Uncommitted Bug
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix window.opener type from any to correct type
Type Sep 9, 2026
window.opener as nullable WindowProxy
Ryan Cavanaugh (RyanCavanaugh)
requested changes
Sep 9, 2026
Ryan Cavanaugh (RyanCavanaugh)
left a comment
Ryan Cavanaugh (RyanCavanaugh)
left a comment
Member
There was a problem hiding this comment.
Copilot just remove the test, we don't add tests for trivial DOM changes
Copilot started work on behalf of
Ryan Cavanaugh (RyanCavanaugh)
September 9, 2026 17:46
View session
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Sep 9, 2026
Ryan Cavanaugh (RyanCavanaugh)
marked this pull request as ready for review
September 9, 2026 17:54
Contributor
Author
Removed the test and generated baselines in f2801e0c. |
Member
|
This is a generated file so I assume this goes to the other repo? |
Member
|
🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.openerwas declared asany, losing both the opener proxy type and its nullability.Change
Window.openerand globalopenerasWindowProxy | null.