Fix race in write loop marshal recovery test - #64215
Open
John Favret (johnfav03) wants to merge 1 commit into
Open
Fix race in write loop marshal recovery test#64215John Favret (johnfav03) wants to merge 1 commit into
John Favret (johnfav03) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The revised test removes the reported scheduling race while preserving coverage of recovery and subsequent response delivery.
Pull request overview
Makes the marshal-recovery test deterministic by removing pipe, goroutine, and timeout synchronization.
Changes:
- Adds a writer that records responses and cancels after two successful writes.
- Runs the write loop synchronously and validates recorded responses.
File summaries
| File | Description |
|---|---|
tsc/internal/lsp/server_test.go |
Reworks marshal-recovery test synchronization. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to microsoft/typescript-go#4896 and the racy test report:
microsoft/typescript-go#4896 (comment)