Fix FSEvents watches with mismatched path casing - #64219
Closed
John Favret (johnfav03) wants to merge 1 commit into
Closed
Fix FSEvents watches with mismatched path casing#64219John Favret (johnfav03) wants to merge 1 commit into
John Favret (johnfav03) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Member
|
Doesn't this restore the code we had to remove? Related #64210 (my huge attempt to fix this once and for all) |
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64089
WatchManagermay use casing that differs from disk. SinceFSEventsreports disk casing while macOSRealpathpreserves caller casing,fswatch’s case-sensitive path comparison dropped those events.