build: improve Makefile linking - #65927
Open
jasnell wants to merge 1 commit into
Open
Conversation
It appears that our Makefile was performing some redundant build steps in CI, adding time to each CI run. This tries to improve things. Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
build
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65927 +/- ##
==========================================
- Coverage 92.40% 90.18% -2.23%
==========================================
Files 417 771 +354
Lines 188989 265444 +76455
Branches 28924 50441 +21517
==========================================
+ Hits 174642 239400 +64758
- Misses 14015 16979 +2964
- Partials 332 9065 +8733 🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that our Makefile was performing some redundant build steps in CI, adding time to each CI run. This tries to improve things. It's been forever since I've messed around with
Makefilechanges so I had the AI do a review pass and tweak a couple things but otherwise this was handrolled and absolutely needs a verification pass.Running locally, the FFI guard step was taking 16.8 seconds to build locally before this change. After this it was only 0.18 seconds by eliminating the redudancy.
@nodejs/build folks... care to take a look?