Skip to content

test: fix flaky common WPT inspector test - #65937

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:deflake-wpt-inspect
Open

test: fix flaky common WPT inspector test#65937
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:deflake-wpt-inspect

Conversation

@inoway46

@inoway46 inoway46 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

test/parallel/test-common-wpt-inspect.js occasionally times out while waiting for Debugger.paused in the macOS CI job.

The inspector connection can be established before the WPT child reaches its startup wait. In that case, Runtime.runIfWaitingForDebugger can be sent too early, leaving the child blocked in the startup wait.

Wait for NodeRuntime.waitingForDebugger before resuming the target, consistent with other inspector tests (https://github.com/nodejs/node/blob/main/test/parallel/test-esm-loader-hooks-inspect-brk.js#L17-L25).

Failed CI runs

Wait for the WPT child to reach its startup wait before sending
Runtime.runIfWaitingForDebugger.

Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Assisted-by: Codex
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 9, 2026
@inoway46
inoway46 marked this pull request as ready for review September 9, 2026 11:52
@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Sep 9, 2026
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (b3fb344) to head (f411c2c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65937      +/-   ##
==========================================
+ Coverage   90.16%   90.17%   +0.01%     
==========================================
  Files         771      771              
  Lines      265434   265434              
  Branches    50450    50460      +10     
==========================================
+ Hits       239332   239365      +33     
+ Misses      17045    17011      -34     
- Partials     9057     9058       +1     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants