tools: add resume-ci label handling - #65945
Open
panva wants to merge 2 commits into
Open
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
Member
|
I haven't yet looked into the details but a question: I assume that resume-ci will fail if new commits have been added since the last run? |
Member
Author
yes. |
aduh95
reviewed
Sep 9, 2026
| --repo "$GITHUB_REPOSITORY" \ | ||
| --label 'resume-ci' \ | ||
| --json 'number' \ | ||
| --search 'review:approved' \ |
Contributor
There was a problem hiding this comment.
I haven't yet looked into the details but a question: I assume that resume-ci will fail if new commits have been added since the last run?
No it won't be picked up until it's approved
Member
Author
There was a problem hiding this comment.
Well, if an approval for the latest commit is there and [resume-ci] is still present then it will fail to start and report such.
aduh95
reviewed
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
[resume-ci]label handling alongside[request-ci]. Approved PRs are processed by the scheduled workflow usingncu-ci resume. Failed attempts receive[resume-ci-failed]and a comment with diagnostic output.Both scripts refuse their operation when the other request label is present.
Before merging:
ncu-ci resume.@node-core/utilsrelease containing that change.[resume-ci]label in nodejs/node.[resume-ci-failed]label in nodejs/node.