gh-157242: Leave bytearray unchanged if resize() fails - #157243
Open
vstinner wants to merge 2 commits into
Open
Conversation
If bytearray.resize() or bytearray.take_bytes() fails, leave the bytearray unchanged. If PyBytesWriter_Resize() fails, leave the writer unchanged. Add a new internal _PyBytes_ResizeKeepOnError() function similar to _PyBytes_Resize() but leaves the bytes object unchanged on error.
vstinner
added
the
needs backport to 3.15
vstinner
commented
Sep 10, 2026
| } | ||
| } | ||
| else { | ||
| *pv = PyBytes_FromStringAndSize(PyBytes_AS_STRING(v), newsize); |
Member
Author
vstinner
commented
Sep 10, 2026
| if (ret == -1) { | ||
| obj->ob_bytes_object = Py_GetConstant(Py_CONSTANT_EMPTY_BYTES); | ||
| size = alloc = 0; | ||
| if (_PyBytes_ResizeKeepOnError(&obj->ob_bytes_object, alloc) < 0) { |
Member
Author
There was a problem hiding this comment.
@cmaloney: I'm not sure that this change is correct. Is the bytearray in a consistent state at this point? Especially, after the memmove() call?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If bytearray.resize() or bytearray.take_bytes() fails, leave the bytearray unchanged.
If PyBytesWriter_Resize() fails, leave the writer unchanged.
Add a new internal _PyBytes_ResizeKeepOnError() function similar to _PyBytes_Resize() but leaves the bytes object unchanged on error.