Refresh GitHub theme syntax colors and gutter - #3988
Open
Matei02355 wants to merge 2 commits into
Open
Conversation
Matei02355
marked this pull request as ready for review
September 7, 2026 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled GitHub theme uses an older palette and has no gutterForeground, leaving line numbers at the terminal default instead of gray. Refresh the existing theme using the official GitHub Light Default syntax rules and palette.
Adapt the 49 TextMate rules from primer/github-vscode-theme 6.3.5 (cd78e5e4e7bcf132a6f428ae0f32264bb1b729cf) and its pinned Primer Primitives 7.10.0 palette. Set the foreground to #1f2328 and the gutter to #8c959f, matching the official editorLineNumber.foreground. Reverse equally specific rules to preserve VS Code's last-rule priority under syntect. Preserve bold, italic and underline; syntect does not support strikethrough.
Retain the existing theme name, white background, yellow highlighted-line background and selection settings. Add both MIT notices to asset acknowledgements and document the pinned sources and conversion. The normal asset patch workflow applies and reverses the update; no binary cache is committed.
Validation: four new decorated syntax fixtures (Rust, JavaScript, Markdown and JSON) were generated from a source-built theme cache. Explicit checks verify gray gutters plus the official foreground, keyword, comment and function colors. Monokai control output is unchanged. The patch applies and reverses without fuzz, exactly restoring the pinned source; acknowledgement generation and the repository license check pass. Rendering still follows Sublime syntax scopes and terminal color capabilities.
Fixes #2671.