Replace deprecated serde_yaml with serde_yaml_ng - #3989
Open
Matei02355 wants to merge 3 commits into
Open
Conversation
Matei02355
marked this pull request as ready for review
September 7, 2026 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serde_yaml crate is deprecated. Switch the direct dependency to the published serde_yaml_ng 0.10.0 release through a Cargo dependency alias, keeping existing serialization call sites and the cache metadata format.
Add regression coverage for legacy timestamps and version compatibility, null values and unknown fields, YAML aliases and JSON input, and malformed YAML with an existing cache. The SerdeYamlError variant remains available and still reports parse locations; its wrapped error now comes from the replacement crate. Syntect's separate YAML parser is unchanged.
Validation: 477 tests passed with all features (7 ignored), Clippy with warnings denied and formatting passed, and the library builds without default features using regex-onig. Actual caches built with the old serializer were read by the updated binary and caches built with the updated binary were read by the old binary. The new lockfile checksum matches the published crates.io archive.
Fixes #3164.