fix: validate configured language in plain piped output - #4001
Open
ryanchou1994 wants to merge 2 commits into
Open
fix: validate configured language in plain piped output#4001ryanchou1994 wants to merge 2 commits into
ryanchou1994 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
bat -l InvalidSyntaxwrites to a pipe, it currently copies the input and exits successfully. Forcing colored output reports the unknown language instead. Validate a configured language before creating the simple printer so plain piped output reports the same error, including for empty input. Valid languages still pass the input through unchanged, and output without a configured language keeps lazy syntax loading.The regression tests cover both error cases, language names and extension tokens, unchanged CRLF/tab output, and a damaged syntax cache that plain output does not need to read. The existing attached-option-value test now uses the valid
crontablanguage, retaining its check thatbandninside a language value do not enable line numbering.Validation on Linux with Rust 1.98.0:
cargo test --locked --offline -- --test-threads=2: 455 passed, 5 ignored.cargo fmt -- --check.cargo clippy --locked --offline --all-targets --all-features -- -D warnings.Refs #2372.