fix: --list-themes ignores BAT_OPTS --paging=always - #4002
Open
yunaremaia wants to merge 1 commit into
Open
Conversation
When BAT_OPTS contains --paging=always, --list-themes paginates one theme at a time and hides theme names. Force paging off inside list_themes() so output is always a single non-paged list. Fixes sharkdp#1618
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
BAT_OPTScontains--paging=always, runningbat --list-themespaginatesone theme at a time and hides the theme names, making the command unusable.
Fixes #1618.
Changes
paging_mode = PagingMode::Neverinsidelist_themes()so the outputis always a single non-paged list regardless of
BAT_OPTSor--paging.list_themes_with_paging_always_from_bat_optsthat setsBAT_OPTS=--paging=alwaysand asserts all themes appear in the output.Verification
Before: paged one theme at a time, names hidden.
After: prints all themes in a single list.
All existing
list_themestests still pass.