fix/batches: prevent command injection from repository paths - #1373
Open
cbrnrd wants to merge 3 commits into
Open
fix/batches: prevent command injection from repository paths#1373cbrnrd wants to merge 3 commits into
cbrnrd wants to merge 3 commits into
Conversation
DaedalusG
approved these changes
Sep 8, 2026
…ry-path-to-execute-trusted-helper
…ry-path-to-execute-trusted-helper
cbrnrd
enabled auto-merge (squash)
September 9, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a volume workspace copied extra repository files, it added repository-controlled paths directly to Docker mount arguments and a shell command. A crafted directory name could change the mount configuration and run commands inside the trusted workspace helper. Those commands could read files from the machine running
src.This fixes VULN-140.
Solution
Package the extra files in a temporary tar archive. Validate that every archive path is relative and clean, mount the archive at a fixed location, and extract it with fixed
tararguments. Repository paths are now treated only as data and are not interpreted by Docker or a shell.Verification Evidence
go test ./internal/batches/...