fix/batches: prevent executor environment leakage to steps - #1374
Merged
cbrnrd merged 1 commit intoSep 9, 2026
Conversation
cbrnrd
marked this pull request as ready for review
September 8, 2026 15:47
DaedalusG
approved these changes
Sep 8, 2026
Contributor
Author
Merge activity
|
cbrnrd
force-pushed
the
carterbrainerd-vuln-141-i-can-use-a-reserved-executor-bearer-from-a-normal-v2-batch
branch
from
September 9, 2026 13:27
657dd83 to
f9d1767
Compare
cbrnrd
force-pushed
the
carterbrainerd-vuln-141-i-can-use-a-reserved-executor-bearer-from-a-normal-v2-batch
branch
from
September 9, 2026 13:34
f9d1767 to
ef9c84a
Compare
cbrnrd
deleted the
carterbrainerd-vuln-141-i-can-use-a-reserved-executor-bearer-from-a-normal-v2-batch
branch
September 9, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Batch steps can request environment variables by name. The executor passed its full process environment into this resolver, so a step could request reserved
SRC_EXECUTOR_*values. These values include executor control credentials that must not be available inside an ordinary batch step.This fixes VULN-141.
Solution
Filter the reserved
SRC_EXECUTOR_*namespace from the outer environment before resolving step variables. The filter is applied at the step execution boundary, so it covers every caller and also protects future variables in the reserved namespace. Normal environment variables and explicit step values continue to work.Verification Evidence
SRC_EXECUTOR_*outer variables resolve to empty values.go test ./internal/batches/...go test ./cmd/src