test(app_config) :: test the documented connection timeout defaults - #1436
Open
81reap wants to merge 1 commit into
Open
test(app_config) :: test the documented connection timeout defaults#143681reap wants to merge 1 commit into
81reap wants to merge 1 commit into
Conversation
`configuration.md` documents that (1) the idle timeout defaults to 30 minutes, (2) the maximum lifetime to an hour, (3) that SQLite doesn't have those limits, and (4) that `0` disables the timeout. Adds tests for these cases.
81reap
marked this pull request as ready for review
September 7, 2026 05:28
lovasoa
changed the title
lovasoa
changed the title
lovasoa
requested changes
Sep 10, 2026
Comment on lines
+882
to
+899
| assert_eq!( | ||
| config.database_connection_max_lifetime, | ||
| Some(Duration::from_mins(2)) | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn connection_timeouts_fall_back_to_the_documented_defaults() { | ||
| let config = config_with_timeouts(r#"{"database_url": "postgres://localhost/test"}"#); | ||
| assert_eq!( | ||
| config.database_connection_idle_timeout, | ||
| Some(Duration::from_mins(30)) | ||
| ); | ||
| assert_eq!( | ||
| config.database_connection_max_lifetime, | ||
| Some(Duration::from_hours(1)) | ||
| ); | ||
|
|
Collaborator
There was a problem hiding this comment.
you can add tests for the zero = None logic if you want. But we should not assert the default configuration values. These tests just add weight and have zero bug-catching power. They do not prevent the docs and actual values from drifting, they just add toil when changing defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configuration.mddocuments that (1) the idle timeout defaults to 30 minutes, (2) the maximum lifetime to an hour, (3) that SQLite doesn't have those limits, and (4) that0disables the timeout. Adds tests for these cases.discovered by #1396
SQLPage/configuration.md
Lines 18 to 19 in 6d32b40